Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated vector episodes #39

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Updated vector episodes #39

wants to merge 28 commits into from
+377 −493

Conversation

cforgaci
Copy link
Collaborator

@cforgaci cforgaci commented Mar 11, 2024 •
edited
Loading

This PR contains the following changes:

Episode 5. Introduction to Geospatial Concepts

  • Small fixes in phrasing and links

Episode 6. Open and Plot Vector Layers

  • Phrasing improved, more explanation given, and usage of terms made more consistent

Episode 7. Explore and plot by vector layer attributes

  • Phrasing improved, more explanation given, and usage of terms made more consistent
  • Extra step removed from the challenge with motorways (skipped in the last workshop)
  • Challenge with NL data from the end of the lesson removed entirely (skipped in the last workshop)
  • Section on adding a plot legend removed entirely (skipped during the last workshop)
  • Part of the lesson transformed into a challenge (skipped in the last workshop)

Episode 8. Plot multiple shapefiles

  • Phrasing improved, more explanation given, and usage of terms made more consistent
  • One large code chunk removed to avoid repetition

Episode 9. Handling Spatial Projections & CRS

  • Small fixes in phrasing and code chunks

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files or spoofing.

Results of any additional workflows will appear here when they are done.

github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
@actions-user
differences for PR #39
fda549c
@cforgaci cforgaci marked this pull request as ready for review March 12, 2024 12:20
@cforgaci cforgaci self-assigned this Mar 12, 2024
@cforgaci cforgaci added type:enhancement Propose enhancement to the lesson type:formatting Formatting needs to be fixed type:clarification Suggest change for make lesson clearer labels Mar 12, 2024
github-actions bot pushed a commit that referenced this pull request Mar 12, 2024
@actions-user
differences for PR #39
4dffe06
@cforgaci
Copy link
Collaborator Author

cforgaci commented Apr 17, 2024 •
edited
Loading

Fixes suggested by Ana:

Episode 5:

  • avoid referring to figures with 'above' and 'below'
  • make keypoint 2 more specific
  • add scale in maps shown in upcoming episodes, or at least make it clear that plot axes have the fucntion of showing the scale
  • we do not introduce vector and raster data... let's add a section "Types of geospatial data"
  • incl. disambiguation of "vector" in part 1 and as a geospatial data type

Episode 6

  • after introducign sf, explain the difference between qgis and R... could be illustrated with a screenshot from QGIS... should be added on the slides as well. we show this in episode 10, refer back to 9
  • explain that shapefile is a legacy format, still in use, but geopackages are increasingly used as an alternative... explain why
  • types of vector data... point, line, polygon... slide would be useful somewhere in the beginning of episode 9
  • show overview diagram of vector/raster + subtypes at the end of the workshop
  • with CRS refer to our explanation of CRS instead of the Carpentries episode

Episode 7

  • factors need to be well explained in the first part, and here we refer back to that @KyriJanssen, @fcjerome
  • same applies to the pipe in part 1 @KyriJanssen, @fcjerome
  • plotting neighbourhoods (wijken) of delft, possibly as a replacement of plotting municipal boundaries
  • consistent use of terms such as "fields" in the context of data frames and sf objects, to be mentioned both in part 2 and in this episode

Episode 9

  • add text at the beginning introducing the episode and linking back to previous episodes
  • add scale to map and/or do that at the end of the workshop
  • link to part 4 why layers need to be in the same CRS... now, ggplot reprojects on the fly for visualisation purposes... but it is important later for geoprocessing... explain this at the end of the episode in a short paragraph... this can be made more explicit in the key point

github-actions bot pushed a commit that referenced this pull request May 1, 2024
@actions-user
differences for PR #39
0b884bd
@cforgaci cforgaci requested a review from javisanmillan May 2, 2024 07:33
github-actions bot pushed a commit that referenced this pull request May 2, 2024
@actions-user
differences for PR #39
01aa2e7
@cforgaci cforgaci requested a review from iurriayanez May 6, 2024 14:22
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@actions-user
differences for PR #39
c51a1df
iurriayanez
iurriayanez reviewed May 20, 2024
View reviewed changes
Copy link
Collaborator

@iurriayanez iurriayanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I identified an inconsistency in one of the concepts used that was changed only once (attributes/fields).

episodes/10-explore-and-plot-by-vector-layer-attributes.Rmd Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iurriayanez iurriayanez iurriayanez left review comments

@ClementineCttn ClementineCttn Awaiting requested review from ClementineCttn

@ana-5r ana-5r Awaiting requested review from ana-5r

@javisanmillan javisanmillan Awaiting requested review from javisanmillan

At least 1 approving review is required to merge this pull request.

Assignees

@cforgaci cforgaci

Labels
type:clarification Suggest change for make lesson clearer type:enhancement Propose enhancement to the lesson type:formatting Formatting needs to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cforgaci @iurriayanez